Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useReducer for dataset creation #20945

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Aug 2, 2022

SUMMARY

This creates the basic reducer hook for the Dataset Creation screen that is currently in process of being implemented.

More actions will be added, but this should be considered the skeleton of the reducer.

Most important to note is the hierarchical nature of the selection actions, database selection should flush tables and schemas, schema selection should do tables, etc.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #20945 (02e0c2c) into master (9350bba) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 02e0c2c differs from pull request most recent head c4e06ea. Consider uploading reports for the commit c4e06ea to get more accurate results

@@            Coverage Diff             @@
##           master   #20945      +/-   ##
==========================================
- Coverage   66.34%   66.33%   -0.01%     
==========================================
  Files        1767     1767              
  Lines       67286    67295       +9     
  Branches     7140     7144       +4     
==========================================
  Hits        44643    44643              
- Misses      20816    20824       +8     
- Partials     1827     1828       +1     
Flag Coverage Δ
javascript 52.10% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/views/CRUD/data/dataset/DatasetPage/index.tsx 0.00% <0.00%> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 67.60% <0.00%> (-1.41%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 52.45% <0.00%> (+0.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-53583/create-redux-state-setup-listviewresource branch from 269b347 to fa96e01 Compare August 2, 2022 21:32
@AAfghahi AAfghahi marked this pull request as ready for review August 2, 2022 21:33
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-53583/create-redux-state-setup-listviewresource branch 2 times, most recently from 26fc021 to c3d9c70 Compare August 2, 2022 21:52
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-53583/create-redux-state-setup-listviewresource branch from c3d9c70 to c4e06ea Compare August 5, 2022 15:08
@AAfghahi AAfghahi merged commit f89ba0c into master Aug 5, 2022
@AAfghahi AAfghahi deleted the arash.afghahi/sc-53583/create-redux-state-setup-listviewresource branch August 5, 2022 16:36
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants