Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to sync columns when dataset name has '+' #21019

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

When editing a dataset, attempting to sync columns from source might fail if the dataset name has special character.
The table name is sent as a query param to the API and it's not properly encoded.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-08-08.at.20.09.58.mov

After:

new.mov

TESTING INSTRUCTIONS

  1. Create a dataset with name “Vehicle Sales +”
  2. Edit the dataset
  3. Navigate to columns
  4. Click on SYNC COLUMNS FROM SOURCE
  5. Will get error message: Dataset does not exist

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21019 (6fcadc6) into master (846529a) will increase coverage by 0.00%.
The diff coverage is 94.11%.

❗ Current head 6fcadc6 differs from pull request most recent head 20ed9e2. Consider uploading reports for the commit 20ed9e2 to get more accurate results

@@           Coverage Diff           @@
##           master   #21019   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1767     1767           
  Lines       67335    67349   +14     
  Branches     7144     7145    +1     
=======================================
+ Hits        44678    44691   +13     
  Misses      20829    20829           
- Partials     1828     1829    +1     
Flag Coverage Δ
javascript 52.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 65.61% <0.00%> (-0.27%) ⬇️
superset/connectors/sqla/models.py 90.32% <100.00%> (-0.01%) ⬇️
superset/db_engine_specs/base.py 88.43% <100.00%> (+0.23%) ⬆️
superset/models/core.py 88.75% <100.00%> (+0.05%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@rusackas
Copy link
Member

Re-running E2E tests, hoping to merge if they make it! 🤞

@rusackas rusackas merged commit 0c84203 into apache:master Aug 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants