Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to show view as table modal #21025

Merged

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

fix the "view as table" in the dashboard is unable to show when the second load.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

unable.to.show.view.as.table.mov

After

view.as.table.after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review August 9, 2022 08:09
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #21025 (d1f1064) into master (03764e6) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master   #21025      +/-   ##
==========================================
- Coverage   66.35%   66.35%   -0.01%     
==========================================
  Files        1767     1767              
  Lines       67348    67354       +6     
  Branches     7144     7146       +2     
==========================================
  Hits        44691    44691              
- Misses      20829    20834       +5     
- Partials     1828     1829       +1     
Flag Coverage Δ
javascript 52.10% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/DataTablesPane/components/useResultsPane.tsx 84.78% <25.00%> (-12.72%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rusackas
Copy link
Member

rusackas commented Aug 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

@rusackas Ephemeral environment spinning up at http://52.11.118.90:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit dfe5a04 into apache:master Aug 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants