Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing IconType on Icons #21218

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

justinpark
Copy link
Member

SUMMARY

This commit updates the IconType for Icons component to fix the type error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before:

Screen Shot 2022-08-26 at 2 19 11 PM

  • After:

Screen Shot 2022-08-26 at 2 19 19 PM

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #21218 (3f97500) into master (d41f44f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21218   +/-   ##
=======================================
  Coverage   66.37%   66.37%           
=======================================
  Files        1781     1781           
  Lines       67929    67929           
  Branches     7255     7255           
=======================================
  Hits        45085    45085           
  Misses      20981    20981           
  Partials     1863     1863           
Flag Coverage Δ
javascript 52.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie self-requested a review August 29, 2022 06:41
@ktmud ktmud merged commit 1aa1864 into apache:master Aug 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants