Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minor Applitools enhancements #21239

Merged
merged 5 commits into from
Aug 29, 2022
Merged

chore: Minor Applitools enhancements #21239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d9c426
Merge branch 'master' of https://github.com/apache/superset
geido Aug 22, 2022
3190c98
Merge branch 'master' of https://github.com/apache/superset
geido Aug 26, 2022
b3acc3e
Enhance logging
geido Aug 29, 2022
5ad440e
Merge branch 'master' of https://github.com/apache/superset into chor…
geido Aug 29, 2022
f348a03
Update conf
geido Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/cypress-base/applitools.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ module.exports = {
apiKey: process.env.APPLITOOLS_API_KEY,
batchId: process.env.APPLITOOLS_BATCH_ID,
batchName: process.env.APPLITOOLS_BATCH_NAME,
browser: [{ width: 1000, height: 660, name: 'chrome' }],
browser: [{ width: 1920, height: 1080, name: 'chrome' }],
failCypressOnDiff: false,
isDisabled: false,
showLogs: false,
testConcurrency: 10,
ignoreCaret: true,
};
4 changes: 2 additions & 2 deletions superset-frontend/cypress-base/cypress/integration/chart_list/chartlist.applitools.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ describe('charts list view', () => {
cy.eyesOpen({
testName: 'Charts list-view',
});
cy.eyesCheckWindow('Charts loaded');
cy.eyesCheckWindow('Charts list-view loaded');
});

it('should load the Charts card list', () => {
cy.get('[aria-label="card-view"]').click();
cy.eyesOpen({
testName: 'Charts card-view',
});
cy.eyesCheckWindow('Charts loaded');
cy.eyesCheckWindow('Charts card-view loaded');
});
});
4 changes: 2 additions & 2 deletions ...frontend/cypress-base/cypress/integration/dashboard_list/dashboardlist.applitools.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ describe('dashboard list view', () => {
cy.eyesOpen({
testName: 'Dashboards list-view',
});
cy.eyesCheckWindow('Dashboards loaded');
cy.eyesCheckWindow('Dashboards list-view loaded');
});

it('should load the Dashboards card list', () => {
cy.get('[aria-label="card-view"]').click();
cy.eyesOpen({
testName: 'Dashboards card-view',
});
cy.eyesCheckWindow('Dashboards loaded');
cy.eyesCheckWindow('Dashboards card-view loaded');
});
});