Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix act errors in SqlEditorLeftBar test #21363

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Sep 7, 2022

SUMMARY

This PR fixes 12 act errors in superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx

Note: I also cleaned up the renders.

TESTING INSTRUCTIONS

  • cd into superset-frontend/src/SqlLab/components/SqlEditorLeftBar
  • run npm run test superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #21363 (2622478) into master (ce3d38d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21363      +/-   ##
==========================================
- Coverage   66.61%   66.60%   -0.01%     
==========================================
  Files        1791     1791              
  Lines       68481    68546      +65     
  Branches     7299     7312      +13     
==========================================
+ Hits        45617    45658      +41     
- Misses      20978    21007      +29     
+ Partials     1886     1881       -5     
Flag Coverage Δ
hive 52.97% <ø> (ø)
javascript 52.79% <ø> (+0.01%) ⬆️
mysql 80.83% <ø> (ø)
postgres 80.88% <ø> (ø)
presto 52.87% <ø> (ø)
python 81.36% <ø> (ø)
sqlite 79.43% <ø> (ø)
unit 50.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 84.21% <0.00%> (-15.79%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-5.80%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 95.23% <0.00%> (+6.34%) ⬆️
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx 27.77% <0.00%> (+16.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 0601b2d into master Sep 8, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/sqleditorleftbar-act-cleanup branch September 8, 2022 16:30
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants