Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixes act errors in TableView test #21375

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes 51 act errors in superset-frontend/src/components/TableView.test.tsx

TESTING INSTRUCTIONS

  • Execute the component tests
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #21375 (39656e1) into master (0601b2d) will increase coverage by 0.00%.
The diff coverage is 90.14%.

❗ Current head 39656e1 differs from pull request most recent head 88c8608. Consider uploading reports for the commit 88c8608 to get more accurate results

@@           Coverage Diff           @@
##           master   #21375   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files        1791     1791           
  Lines       68538    68559   +21     
  Branches     7310     7319    +9     
=======================================
+ Hits        45655    45671   +16     
  Misses      21002    21002           
- Partials     1881     1886    +5     
Flag Coverage Δ
javascript 52.80% <90.14%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/components/MetadataBar/ContentConfig.tsx 85.00% <ø> (ø)
superset/datasets/api.py 87.29% <ø> (ø)
...ard/components/DrillDetailPane/DrillDetailPane.tsx 81.01% <76.19%> (-1.75%) ⬇️
...rontend/src/components/MetadataBar/MetadataBar.tsx 96.00% <96.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 834ec7e into apache:master Sep 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants