Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cache): update datasource -> dataset #21670

Merged
merged 2 commits into from
Oct 6, 2022
Merged

docs(cache): update datasource -> dataset #21670

merged 2 commits into from
Oct 6, 2022

Conversation

nytai
Copy link
Member

@nytai nytai commented Oct 2, 2022

Fixes a legacy reference to datasource which should be dataset now

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #21670 (c031fe0) into master (61bd696) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21670      +/-   ##
==========================================
- Coverage   66.85%   66.82%   -0.03%     
==========================================
  Files        1798     1798              
  Lines       68827    68827              
  Branches     7333     7333              
==========================================
- Hits        46011    45997      -14     
- Misses      20931    20951      +20     
+ Partials     1885     1879       -6     
Flag Coverage Δ
hive 52.91% <ø> (ø)
javascript 53.16% <ø> (-0.04%) ⬇️
mysql 78.23% <ø> (ø)
postgres 78.29% <ø> (ø)
presto 52.81% <ø> (ø)
python 81.42% <ø> (ø)
sqlite 76.79% <ø> (ø)
unit 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.43% <0.00%> (-5.76%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenLYZ stephenLYZ merged commit d6a8218 into master Oct 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the nytai-patch-1 branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants