Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): Handle String errors in DatabaseModal #21709

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

At some point we stopped handling and displaying API errors coming as raw strings in the DatabaseModal. We are bringing that back, so for example, if someone tries to connect a BigQuery DB using credential JSON files with no roles in it, an error gets displayed vs no indication at all.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test

TESTING INSTRUCTIONS

Create a new Service Account on Google Console. Doesn’t grant any Role to it.
Download the Service Account key via jSON.
Access your Workspace.
Hover over the + on the top right corner, then navigate to Data > Connect database.
Select Google BigQuery.
Click on Choose File to upload the JSON.
Click on CONNECT.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Showing string errors not only object ones
- Add tests that cover error display
@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title fix(database): Handle string errors in DatabaseModal fix(database): Handle String errors in DatabaseModal Oct 5, 2022
@yousoph
Copy link
Member

yousoph commented Oct 5, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

@yousoph Ephemeral environment spinning up at http://34.217.194.45:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #21709 (81ad09d) into master (7b66e0b) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master   #21709   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1799     1799           
  Lines       68875    68877    +2     
  Branches     7319     7320    +1     
=======================================
+ Hits        46044    46051    +7     
+ Misses      20944    20937    -7     
- Partials     1887     1889    +2     
Flag Coverage Δ
javascript 53.16% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 34.54% <33.33%> (+1.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit 97273f5 into apache:master Oct 6, 2022
AnushaErrabelli pushed a commit to preset-io/superset that referenced this pull request Oct 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants