chore: cleanup on catalog check for Gsheets #21738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21738 +/- ##
==========================================
- Coverage 66.84% 66.83% -0.01%
==========================================
Files 1799 1800 +1
Lines 68902 68937 +35
Branches 7324 7335 +11
==========================================
+ Hits 46057 46077 +20
- Misses 20955 20967 +12
- Partials 1890 1893 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
reviewed
Oct 7, 2022
| @@ -744,11 +744,11 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ | |||
| engine_information, | |||
| }, | |||
| }); | |||
| } | |||
There was a problem hiding this comment.
is this PR changing indentation/block scope too?
There was a problem hiding this comment.
yea i moved it inside of the if so i have context for engine
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Instead of using the string let's use enum provided in types for checking
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION