Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dataset left panel now uses client side search #21770

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Oct 11, 2022

SUMMARY

This PR changed the left panel's search functionality from server side searching to client side searching.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

unsuccessfulTableSearch

AFTER:

successfulTableSearch

TESTING INSTRUCTIONS

  • Go to http://localhost:9000/dataset/add/?testing
  • Select a database and schema
  • Search for a table name
  • Observe that the search functions correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #21770 (4105585) into master (60bab42) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           master   #21770     +/-   ##
=========================================
  Coverage   66.82%   66.82%             
=========================================
  Files        1797     1802      +5     
  Lines       68752    71346   +2594     
  Branches     7325     8176    +851     
=========================================
+ Hits        45943    47678   +1735     
- Misses      20935    21653    +718     
- Partials     1874     2015    +141     
Flag Coverage Δ
hive 52.90% <ø> (ø)
javascript 53.69% <100.00%> (+0.53%) ⬆️
mysql 78.21% <ø> (ø)
postgres 78.27% <ø> (ø)
presto 52.80% <ø> (ø)
python 81.40% <ø> (ø)
sqlite 76.77% <ø> (ø)
unit 50.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 84.61% <100.00%> (+36.99%) ⬆️
...nd/src/dashboard/components/gridComponents/Row.jsx 60.93% <0.00%> (-14.07%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx 51.21% <0.00%> (-7.12%) ⬇️
...c/components/ErrorMessage/DatabaseErrorMessage.tsx 66.66% <0.00%> (-6.07%) ⬇️
...rset-frontend/src/components/Chart/chartReducer.ts 22.66% <0.00%> (-2.34%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 44.79% <0.00%> (-1.77%) ⬇️
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 4.00% <0.00%> (-1.56%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 82.41% <0.00%> (-1.26%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.79% <0.00%> (-1.15%) ⬇️
...ontend/src/dashboard/components/dnd/handleHover.js 9.09% <0.00%> (-0.91%) ⬇️
... and 82 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 11, 2022
@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review October 11, 2022 20:11
@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://54.70.240.166:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams lyndsiWilliams added the need:qa-review Requires QA review label Oct 11, 2022
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested and code looks good. Thanks for the test!

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lyndsiWilliams lyndsiWilliams merged commit 8f4415b into master Oct 17, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/client-side-search branch October 17, 2022 20:02
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants