Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Fix spacing on Schedule option in SqlEditor dropdown #21832

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes the spacing on the Schedule option in the SqlEditor dropdown.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

scheduleBefore

AFTER:

scheduleAfter

TESTING INSTRUCTIONS

  • Go to SQL Lab
  • Click the SQL Editor dropdown
  • Observe that the spacing for Schedule is consistent with the other options

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review October 17, 2022 13:46
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #21832 (cd06f36) into master (52d33b0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21832      +/-   ##
==========================================
- Coverage   66.90%   66.89%   -0.01%     
==========================================
  Files        1805     1805              
  Lines       69073    69064       -9     
  Branches     7369     7369              
==========================================
- Hits        46214    46203      -11     
- Misses      20952    20953       +1     
- Partials     1907     1908       +1     
Flag Coverage Δ
hive 52.92% <ø> (ø)
javascript 53.27% <ø> (-0.02%) ⬇️
mysql 78.35% <ø> (ø)
postgres 78.41% <ø> (ø)
presto 52.82% <ø> (ø)
python 81.47% <ø> (ø)
sqlite 76.90% <ø> (ø)
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 20.75% <ø> (ø)
...et-frontend/src/dashboard/actions/dashboardInfo.ts 50.00% <0.00%> (-11.54%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 53.57% <0.00%> (-1.48%) ⬇️
...-frontend/src/dashboard/reducers/dashboardState.js 76.08% <0.00%> (-0.51%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 59.85% <0.00%> (-0.45%) ⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx 7.14% <0.00%> (-0.12%) ⬇️
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/index.ts 100.00% <0.00%> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 66.66% <0.00%> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx 85.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyndsiWilliams
Copy link
Member Author

/testenv up

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://54.187.98.174:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams lyndsiWilliams merged commit fcb9800 into master Oct 17, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-schedule-placement branch October 17, 2022 19:54
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants