Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update typo in docker-add-drivers.mdx #21965

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

jankatins
Copy link
Contributor

Fixes a simple typo we saw while following the tutorial: make take a while -> may take a while

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@jankatins jankatins changed the title Update typo in docker-add-drivers.mdx Fix: Update typo in docker-add-drivers.mdx Nov 1, 2022
@jankatins
Copy link
Contributor Author

Fixed the pr title

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Title is almost there, PR lint is failing because the first letter of the title should be lowercase 😁

@lyndsiWilliams lyndsiWilliams changed the title Fix: Update typo in docker-add-drivers.mdx fix: Update typo in docker-add-drivers.mdx Dec 9, 2022
@srinify srinify merged commit 85c9480 into apache:master Dec 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants