Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade antd@4.10.3 #22007

Merged
merged 8 commits into from
Nov 17, 2022
Merged

chore: Upgrade antd@4.10.3 #22007

merged 8 commits into from
Nov 17, 2022

Conversation

geido
Copy link
Member

@geido geido commented Nov 2, 2022

SUMMARY

Upgrades Antd to version 4.10.3, in order to use property maxTagCount="responsive" in the Select component enabling dropdowns to display tags responsively.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

N.A.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #22007 (38764d5) into master (cd1b379) will not change coverage.
The diff coverage is n/a.

❗ Current head 38764d5 differs from pull request most recent head b49818e. Consider uploading reports for the commit b49818e to get more accurate results

@@           Coverage Diff           @@
##           master   #22007   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1815     1815           
  Lines       69575    69575           
  Branches     7486     7486           
=======================================
  Hits        46665    46665           
  Misses      20974    20974           
  Partials     1936     1936           
Flag Coverage Δ
javascript 53.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

@geido Adding the code below in superset-ui-core/test/__mocks__/resizer-observer-polyfill.ts should fix the test error:

export default function ResizeObserver(callback: ObserveCallback) {
  return {
    disconnect() {
      allCallbacks.splice(allCallbacks.indexOf(callback), 1);
    },
    observe() {
      if (callback) {
        allCallbacks.push(callback);
      }
    },
    unobserve() { <-- ADD THIS
      if (callback) {
        allCallbacks.splice(allCallbacks.indexOf(callback), 1);
      }
    },
  };
}

@geido
Copy link
Member Author

geido commented Nov 8, 2022

Nice catch @michael-s-molina. I don't know how I didn't see this before!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 8, 2022
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@geido geido added the need:qa-review Requires QA review label Nov 9, 2022
Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - clicked around home, Explore Dashboard view/edit, datasets, SQL Lab and everything looked fine.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, run automation and did not see any blocker

@geido geido merged commit d352b74 into master Nov 17, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/upgrade-antd@4.10.3 branch March 26, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants