Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix act errors in DndMetricSelect test #22048

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 46 act errors in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend
  • run npm run test superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #22048 (e901ca8) into master (aa48cae) will not change coverage.
The diff coverage is n/a.

❗ Current head e901ca8 differs from pull request most recent head 1c8c488. Consider uploading reports for the commit 1c8c488 to get more accurate results

@@           Coverage Diff           @@
##           master   #22048   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1815     1815           
  Lines       69575    69575           
  Branches     7486     7486           
=======================================
  Hits        46665    46665           
  Misses      20974    20974           
  Partials     1936     1936           
Flag Coverage Δ
javascript 53.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyndsiWilliams lyndsiWilliams merged commit 7a52b22 into master Nov 7, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-act-errors-dndMetricSelect branch November 7, 2022 18:34
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants