fix: SQL Lab QuerySource via referrer

[john-bodley]

SUMMARY

At Airbnb we've noticed in the logs (see attached) that the QuerySource is undefined which occurs the referrer is of the form .../superset/sqllab i.e., without the trailing /.

Grokking through the code there are a number of examples where the trailing / isn't provided, hence it seems prudent to relax the requirement that the trailing / is required to match queries originating from SQL Lab.

$ git grep "/sqllab?"
docs/docs/installation/sql-templating.mdx:  coworker in Spain the following SQL Lab URL `www.example.com/superset/sqllab?countrycode=ES`
docs/docs/installation/sql-templating.mdx:  and your coworker in the USA the following SQL Lab URL `www.example.com/superset/sqllab?countrycode=US`
superset-frontend/src/SqlLab/components/QueryTable/index.tsx:  const url = `/superset/sqllab?queryId=${id}`;
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:            <a href={`/superset/sqllab?queryId=${id}`}>
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:            window.location.assign(`/superset/sqllab?queryId=${id}`)
superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx:    window.open(`${window.location.origin}/superset/sqllab?new=true`);
superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx:    window.open(`${window.location.origin}/superset/sqllab?savedQueryId=${id}`);
superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx:          `${window.location.origin}/superset/sqllab?savedQueryId=${id}`,
superset-frontend/src/views/CRUD/hooks.ts:      `${window.location.origin}/superset/sqllab?savedQueryId=${id}`,
superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx:  if ('sql' in entity) return `/superset/sqllab?savedQueryId=${entity.id}`;
superset-frontend/src/views/CRUD/welcome/EmptyState.tsx:    [WelcomeTable.SavedQueries]: '/superset/sqllab?new=true',
superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx:            window.location.href = `/superset/sqllab?savedQueryId=${query.id}`;
superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx:              window.location.href = '/superset/sqllab?new=true';
superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx:                window.location.href = `/superset/sqllab?savedQueryId=${q.id}`;
superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx:                url={`/superset/sqllab?savedQueryId=${q.id}`}
superset-frontend/src/views/components/Menu.test.tsx:    url: '/superset/sqllab?new=true',
superset-frontend/src/views/components/RightMenu.test.tsx:    url: '/superset/sqllab?new=true',
superset-frontend/src/views/components/RightMenu.tsx:      url: '/superset/sqllab?new=true',
superset/jinja_context.py:        `?foo=bar`, as in `{domain}/superset/sqllab?foo=bar`. Then if your query is
superset/models/sql_lab.py:            <a href="/superset/sqllab?savedQueryId={self.id}">
superset/models/sql_lab.py:        return "/superset/sqllab?savedQueryId={0}".format(self.id)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22172 (4439524) into master (7e54b88) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22172      +/-   ##
==========================================
- Coverage   67.00%   67.00%   -0.01%     
==========================================
  Files        1835     1835              
  Lines       69964    69964              
  Branches     7588     7588              
==========================================
- Hits        46879    46878       -1     
- Misses      21119    21120       +1     
  Partials     1966     1966              

Flag	Coverage Δ
hive	52.61% <0.00%> (ø)
javascript	53.81% <ø> (ø)
mysql	78.14% <0.00%> (ø)
postgres	78.20% <0.00%> (-0.01%)	⬇️
presto	52.50% <0.00%> (ø)
python	81.39% <0.00%> (-0.01%)	⬇️
sqlite	76.66% <0.00%> (ø)
unit	50.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/models/core.py	90.50% <0.00%> (ø)
superset/views/core.py	76.11% <0.00%> (-0.08%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

LGTM