Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure shared-contrls modules #22224

Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 25, 2022

SUMMARY

The original goal of this PR is that the XAxisSortControl should be moved into shared-controls modules(refer to PR). So, do a refactor in this part.

  • Remove unused file in shared-module: legacySortBy.tsx
  • The shared-controls is declared as a module and creates a index.ts in it.
  • Use Named-import instead of Default-import when performing the import statement on the shared-controls.
  • Rename the emitFilterControl.ts to the customControls.ts, the goal is that this file should contain more custom controls in the future.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/a

TESTING INSTRUCTIONS

should pass all CI steps.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #22224 (10eed70) into master (1831e8c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22224      +/-   ##
==========================================
- Coverage   66.90%   66.90%   -0.01%     
==========================================
  Files        1835     1834       -1     
  Lines       69988    69986       -2     
  Branches     7612     7612              
==========================================
- Hits        46825    46823       -2     
  Misses      21197    21197              
  Partials     1966     1966              
Flag Coverage Δ
javascript 53.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...rt-controls/src/shared-controls/customControls.tsx 0.00% <0.00%> (ø)
...rt-controls/src/shared-controls/sharedControls.tsx 53.44% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...i-chart-controls/src/utils/expandControlConfig.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie merged commit b2fcdc5 into apache:master Nov 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants