Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Change horizontal filter bar divider truncation logic #22252

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Nov 29, 2022

SUMMARY

Currently, non-overflowed horizontal native filter dividers follow the following truncation logic:

  • If the divider title is truncated or there is a divider description set or both, the description icon is visible
  • Hovering over the description icon will show one or both of the following:
    • The full title in bold, if the title is truncated
    • The description if present

This PR modifies that behavior to the following:

  • If the divider title is truncated, hovering over the title will show the full title in standard font weight
  • If and only if there is a divider description set, the description icon will be visible and hovering over it will show the full description

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-11-28.at.7.24.56.PM.mov

After:

Screen.Recording.2022-11-28.at.7.19.45.PM.mov

TESTING INSTRUCTIONS

  • For dividers with a non-truncated title and no description, confirm that there is no description icon and no tooltips
  • For dividers with a non-truncated title and a description, confirm that there's no tooltip when hovering over the title and that the description icon is visible and shows a tooltip with the description when hovered over
  • For dividers with a truncated title and no description, confirm that there's a tooltip with the full title when hovering over the truncated title and that there's no description icon
  • For dividers with a truncated title and a description, confirm that there's a tooltip with the full title when hovering over the truncated title and that the description icon is visible and shows a tooltip with the description when hovered over

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the improvement!

@kgabryje kgabryje merged commit 91d1905 into apache:master Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants