Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update time comparison choices (again) #22458

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Dec 19, 2022

SUMMARY

Similar to #11294, this PR adds Y4Y time comparison choices to make it faster to compare with pre-pandemic times.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested review from serenajiang and ktmud and removed request for serenajiang December 19, 2022 19:25
@john-bodley john-bodley marked this pull request as ready for review December 19, 2022 19:25
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #22458 (5cbd4b5) into master (858796b) will not change coverage.
The diff coverage is n/a.

❗ Current head 5cbd4b5 differs from pull request most recent head fde6335. Consider uploading reports for the commit fde6335 to get more accurate results

@@           Coverage Diff           @@
##           master   #22458   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files        1850     1850           
  Lines       70701    70701           
  Branches     7750     7750           
=======================================
  Hits        47292    47292           
  Misses      21393    21393           
  Partials     2016     2016           
Flag Coverage Δ
javascript 53.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may already know this, but freeform time comparisons are already supported:
image

I'm almost wondering if we should replace the current dropdown with a component similar to the time picker, as we don't really need the pre-populated values IMO.

@john-bodley
Copy link
Member Author

@villebro I'm aware of that (and did communicate it to our users), though it seems like they still likely the idea of having it explicitly defined.

@john-bodley john-bodley merged commit 9e81c3a into apache:master Dec 23, 2022
@john-bodley john-bodley deleted the john-bodley--the-before-times branch January 24, 2023 19:26
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 24, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants