Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing unnecessary double spaces, a.k.a. "shotgun holes" #22852

Merged
merged 3 commits into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ const config: ControlPanelConfig = {
description: t(
'Overlay one or more timeseries from a ' +
'relative time period. Expects relative time deltas ' +
'in natural language (example: 24 hours, 7 days, ' +
'in natural language (example: 24 hours, 7 days, ' +
'52 weeks, 365 days). Free text is supported.',
),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ export const timeSeriesSection: ControlPanelSectionConfig[] = [
description: t(
'Overlay one or more timeseries from a ' +
'relative time period. Expects relative time deltas ' +
'in natural language (example: 24 hours, 7 days, ' +
'in natural language (example: 24 hours, 7 days, ' +
'52 weeks, 365 days). Free text is supported.',
),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ export default class EchartsTimeseriesChartPlugin extends ChartPlugin<
credits: ['https://echarts.apache.org'],
description: hasGenericChartAxes
? t(
'Swiss army knife for visualizing data. Choose between step, line, scatter, and bar charts. This viz type has many customization options as well.',
'Swiss army knife for visualizing data. Choose between step, line, scatter, and bar charts. This viz type has many customization options as well.',
)
: t(
'Swiss army knife for visualizing time series data. Choose between step, line, scatter, and bar charts. This viz type has many customization options as well.',
'Swiss army knife for visualizing time series data. Choose between step, line, scatter, and bar charts. This viz type has many customization options as well.',
),
exampleGallery: [{ url: example }],
supportedAnnotationTypes: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const defaultProps = {
const defaultEvt = {
preventDefault: sinon.spy(),
clipboardData: {
getData: sinon.spy(() => ' United States, China , India, Canada, '),
getData: sinon.spy(() => ' United States, China, India, Canada, '),
},
};

Expand Down
10 changes: 5 additions & 5 deletions superset-frontend/src/components/Table/Table.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,16 +310,16 @@ export const Basic: ComponentStory<typeof Table> = args => <Table {...args} />;
function handlers(record: object, rowIndex: number) {
return {
onClick: action(
`row onClick, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
`row onClick, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
), // click row
onDoubleClick: action(
`row onDoubleClick, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
`row onDoubleClick, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
), // double click row
onContextMenu: action(
`row onContextMenu, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
`row onContextMenu, row: ${rowIndex}, record: ${JSON.stringify(record)}`,
), // right button click row
onMouseEnter: action(`Mouse Enter, row: ${rowIndex}`), // mouse enter row
onMouseLeave: action(`Mouse Leave, row: ${rowIndex}`), // mouse leave row
onMouseEnter: action(`Mouse Enter, row: ${rowIndex}`), // mouse enter row
onMouseLeave: action(`Mouse Leave, row: ${rowIndex}`), // mouse leave row
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const buildTree = (
);
} else {
logging.warn(
`Unable to find item with id: ${child} in the dashboard layout. This may indicate you have invalid references in your dashboard and the references to id: ${child} should be removed.`,
`Unable to find item with id: ${child} in the dashboard layout. This may indicate you have invalid references in your dashboard and the references to id: ${child} should be removed.`,
);
}
});
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/explore/controlPanels/sections.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export const NVD3TimeSeries: ControlPanelSectionConfig[] = [
description: t(
'Overlay one or more timeseries from a ' +
'relative time period. Expects relative time deltas ' +
'in natural language (example: 24 hours, 7 days, ' +
'in natural language (example: 24 hours, 7 days, ' +
'52 weeks, 365 days). Free text is supported.',
),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const httpPath = ({
placeholder={t('e.g. sql/protocolv1/o/12345')}
label="HTTP Path"
onChange={changeMethods.onExtraInputChange}
helpText={t('Copy the name of the HTTP Path of your cluster.')}
helpText={t('Copy the name of the HTTP Path of your cluster.')}
/>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Slice(Base):
"second": "PT1S",
"minute": "PT1M",
"5 minute": "PT5M",
"10 minute": "PT10M",
"10 minute": "PT10M",
"half hour": "PT0.5H",
"hour": "PT1H",
"day": "P1D",
Expand Down
2 changes: 1 addition & 1 deletion superset/utils/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def parse_js_uri_path_item(

:param item: a uri path component
:param unquote: Perform unquoting of string using urllib.parse.unquote_plus()
:param eval_undefined: When set to True and item is either 'null' or 'undefined',
:param eval_undefined: When set to True and item is either 'null' or 'undefined',
assume item is undefined and return None.
:return: Either None, the original item or unquoted item
"""
Expand Down
2 changes: 1 addition & 1 deletion superset/views/database/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class DatabaseMixin:
),
"expose_in_sqllab": _("Expose this DB in SQL Lab"),
"allow_run_async": _(
"Operate the database in asynchronous mode, meaning "
"Operate the database in asynchronous mode, meaning "
"that the queries are executed on remote workers as opposed "
"to on the web server itself. "
"This assumes that you have a Celery worker setup as well "
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/celery_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def run_sql(

def drop_table_if_exists(table_name: str, table_type: CtasMethod) -> None:
"""Drop table if it exists, works on any DB"""
sql = f"DROP {table_type} IF EXISTS {table_name}"
sql = f"DROP {table_type} IF EXISTS {table_name}"
database = get_example_database()
with database.get_sqla_engine_with_context() as engine:
engine.execute(sql)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/db_engine_specs/postgres_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_estimate_statement_cost_select_star(self):

cursor = mock.Mock()
cursor.fetchone.return_value = (
"Seq Scan on birth_names (cost=0.00..1537.91 rows=75691 width=46)",
"Seq Scan on birth_names (cost=0.00..1537.91 rows=75691 width=46)",
)
sql = "SELECT * FROM birth_names"
results = PostgresEngineSpec.estimate_statement_cost(sql, cursor)
Expand Down
4 changes: 2 additions & 2 deletions tests/unit_tests/utils/date_parser_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_datetime_eval() -> None:
expected = datetime(2016, 11, 7, 9, 30, 10)
assert result == expected

result = datetime_eval("datetime('today' )")
result = datetime_eval("datetime('today')")
expected = datetime(2016, 11, 7)
assert result == expected

Expand Down Expand Up @@ -308,7 +308,7 @@ def test_get_past_or_future() -> None:

def test_parse_human_datetime() -> None:
with pytest.raises(TimeRangeAmbiguousError):
parse_human_datetime(" 2 days ")
parse_human_datetime("2 days")

with pytest.raises(TimeRangeAmbiguousError):
parse_human_datetime("2 day")
Expand Down