Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes the inputs of native filters modal to have the same width #23477

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Changes the inputs of native filters modal to have the same width.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-03-23.at.19.01.14.mov
Screen.Recording.2023-03-23.at.18.55.26.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #23477 (c6c5204) into master (8f846b7) will increase coverage by 0.00%.
The diff coverage is 97.36%.

❗ Current head c6c5204 differs from pull request most recent head a786a90. Consider uploading reports for the commit a786a90 to get more accurate results

@@           Coverage Diff           @@
##           master   #23477   +/-   ##
=======================================
  Coverage   67.64%   67.65%           
=======================================
  Files        1908     1910    +2     
  Lines       73739    73746    +7     
  Branches     7988     7987    -1     
=======================================
+ Hits        49879    49891   +12     
  Misses      21814    21814           
+ Partials     2046     2041    -5     
Flag Coverage Δ
javascript 53.84% <97.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Filters/FiltersConfigModal/FilterConfigurePane.tsx 100.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 9.09% <0.00%> (ø)
...rsConfigModal/FiltersConfigForm/DependencyList.tsx 52.45% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 55.17% <ø> (ø)
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 76.31% <ø> (-0.61%) ⬇️
...ontrols/src/operators/utils/extractExtraMetrics.ts 100.00% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 64.50% <100.00%> (+0.17%) ⬆️
...c/SqlLab/components/RunQueryActionButton/index.tsx 78.78% <100.00%> (ø)
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 75.32% <100.00%> (+0.32%) ⬆️
.../FiltersConfigModal/FiltersConfigForm/constants.ts 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 27, 2023
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last optional nit. And thanks for doing this - I've been meaning to do something about it, and I'm very happy you actually did something about it! 🎉

@@ -59,7 +60,7 @@ const DefaultValue: FC<DefaultValueProps> = ({
) : (
<SuperChart
height={32}
width={formFilter?.filterType === 'filter_time' ? 350 : 250}
width={formFilter?.filterType === 'filter_time' ? 350 : INPUT_WIDTH}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit of a bycatch - it could be nice to move 350 into constants, too, maybe as TIME_FILTER_INPUT_WIDTH.

@michael-s-molina michael-s-molina merged commit 21578f7 into apache:master Mar 27, 2023
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants