fix: warning of nth-child #23638

justinpark · 2023-04-10T17:39:36Z

SUMMARY

This commit replaces the nth-child css selector by nth-of-type- selector to fix the SSR warning.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Before:

TESTING INSTRUCTIONS

Go to SqlLab and open the developer console
Check the warning message

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

justinpark · 2023-04-10T17:40:27Z

cc: @michael-s-molina @ktmud

rusackas

In theory, this is most likely fine. Did you do any checks to find these parts of the UI and make sure they still look and behave correctly? My only slight worry is that the nth-child selector doesn't take into account element type/class of it's sibling elements, so things might not be the same between the two.

codecov · 2023-04-10T18:36:15Z

Codecov Report

Merging #23638 (5f6fec2) into master (b613167) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f6fec2 differs from pull request most recent head ec9c623. Consider uploading reports for the commit ec9c623 to get more accurate results

@@           Coverage Diff           @@
##           master   #23638   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files        1918     1918           
  Lines       74157    74157           
  Branches     8053     8053           
=======================================
  Hits        50219    50219           
  Misses      21885    21885           
  Partials     2053     2053

Flag	Coverage Δ
javascript	`53.90% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...allel-coordinates/src/ReactParallelCoordinates.jsx	`0.00% <ø> (ø)`
...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx	`0.00% <ø> (ø)`
...qlLab/components/SaveDatasetActionButton/index.tsx	`83.33% <ø> (ø)`
...rset-frontend/src/components/ButtonGroup/index.tsx	`100.00% <ø> (ø)`
...t-frontend/src/components/DropdownButton/index.tsx	`85.00% <ø> (ø)`
...nd/src/components/DropdownSelectableIcon/index.tsx	`94.44% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rusackas · 2023-04-13T16:22:00Z

/testenv up

github-actions · 2023-04-13T16:23:59Z

@rusackas Ephemeral environment spinning up at http://35.163.78.30:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas · 2023-07-25T18:50:50Z

@justinpark is this still on the radar? I love the cleanup work :D

(cherry picked from commit 16cc089)

* fix: is_select with UNION (apache#25290) (cherry picked from commit bb002d6) * fix: Add explicit ON DELETE CASCADE for dashboard_roles (apache#25320) (cherry picked from commit d54e827) * fix(chart): Supporting custom SQL as temporal x-axis column with filter (apache#25126) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix: Use RLS clause instead of ID for cache key (apache#25229) (cherry picked from commit fba66c6) * fix: Improve the reliability of alerts & reports (apache#25239) (cherry picked from commit f672d5d) * fix: DashboardRoles cascade operation (apache#25349) (cherry picked from commit a971a28) * fix: datetime with timezone excel export (apache#25318) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 5ebcd2a) * fix: Workaround for Cypress ECONNRESET error (apache#25399) (cherry picked from commit d76ff39) * fix(sqllab): invalid persisted tab state (apache#25308) (apache#25398) * fix: Rename on_delete parameter to ondelete (apache#25424) (cherry picked from commit 893b45f) * fix: preventing save button from flickering in SQL Lab (apache#25106) (cherry picked from commit 296ff17) * fix: chart import (apache#25425) (cherry picked from commit a4d8f36) * fix: swagger UI CSP error (apache#25368) (cherry picked from commit 1716b9f) * fix: smarter date formatter (apache#25404) (cherry picked from commit f0080f9) * fix(sqllab): invalid start date (apache#25437) * fix(nativeFilters): Speed up native filters by removing unnecessary rerenders (apache#25282) Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> (cherry picked from commit a0eeb4d) * fix(SqlLab): make icon placement even (apache#25372) (cherry picked from commit 11b49a6) * fix: Duplicate items when pasting into Select (apache#25447) (cherry picked from commit 7cf96cd) * fix: update the SQLAlchemy model definition at json column for Log table (apache#25445) (cherry picked from commit e83a76a) * fix(helm chart): set chart appVersion to 3.0.0 (apache#25373) * fix(mysql): handle string typed decimal results (apache#24241) (cherry picked from commit 7eab59a) * fix: Styles not loading because of faulty CSP setting (apache#25468) (cherry picked from commit 0cebffd) * fix(sqllab): error with lazy_gettext for tab titles (apache#25469) (cherry picked from commit ddde178) * fix: Address Mypy issue which is causing CI to fail (apache#25494) (cherry picked from commit 36ed617) * chore: Adds 3.0.1 CHANGELOG * fix: Unable to sync columns when database or dataset name contains `+` (apache#25390) (cherry picked from commit dbe0838) * fix(sqllab): Broken query containing 'children' (apache#25490) (cherry picked from commit b92957e) * chore: Expand error detail on screencapture (apache#25519) (cherry picked from commit ba541e8) * fix: tags permissions error message (apache#25516) (cherry picked from commit 50b0816) * fix: Apply normalization to all dttm columns (apache#25147) (cherry picked from commit 58fcd29) * fix: REST API CSRF exempt list (apache#25590) (cherry picked from commit 549abb5) * fix(RLS): Fix Info Tooltip + Button Alignment on RLS Modal (apache#25400) (cherry picked from commit a6d0e6f) * fix: thubmnails loading - Talisman default config (apache#25486) (cherry picked from commit 52f631a) * fix(Presto): catch DatabaseError when testing Presto views (apache#25559) Co-authored-by: Rui Zhao <zhaorui@dropbox.com> (cherry picked from commit be3714e) * fix(Charts): Set max row limit + removed the option to use an empty row limit value (apache#25579) (cherry picked from commit f556ef5) * fix(window): unavailable localStorage and sessionStorage (apache#25599) * fix: finestTemporalGrainFormatter (apache#25618) (cherry picked from commit 62bffaf) * fix: revert fix(sqllab): Force trino client async execution (apache#24859) (apache#25541) (cherry picked from commit e56e0de) * chore: Updates 3.0.1 CHANGELOG * fix(sqllab): Mistitled for new tab after rename (apache#25523) (cherry picked from commit a520124) * fix(sqllab): template validation error within comments (apache#25626) (cherry picked from commit b370c66) * fix: avoid 500 errors with SQLLAB_BACKEND_PERSISTENCE (apache#25553) (cherry picked from commit 99f79f5) * fix(import): Make sure query context is overwritten for overwriting imports (apache#25493) (cherry picked from commit a0a0d80) * fix: permalink save/overwrites in explore (apache#25112) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> (cherry picked from commit e58a3ab) * fix(header navlinks): link navlinks to path prefix (apache#25495) (cherry picked from commit 51c56dd) * fix: improve upload ZIP file validation (apache#25658) * fix: warning of nth-child (apache#23638) (cherry picked from commit 16cc089) * fix(dremio): Fixes issue with Dremio SQL generation for Charts with Series Limit (apache#25657) (cherry picked from commit be82657) --------- Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> Co-authored-by: Zef Lin <zef@preset.io> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Jack Fragassi <jfragassi98@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com> Co-authored-by: Corbin Bullard <corbindbullard@gmail.com> Co-authored-by: Gyuil Han <cnabro91@gmail.com> Co-authored-by: Celalettin Calis <celalettin1286@gmail.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: mapledan <mapledan829@gmail.com> Co-authored-by: Igor Khrol <khroliz@gmail.com> Co-authored-by: Rui Zhao <105950525+zhaorui2022@users.noreply.github.com> Co-authored-by: Fabien <18534166+frassinier@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: OskarNS <soerensen.oskar@gmail.com>

pull-request-size bot added the size/S label Apr 10, 2023

rusackas reviewed Apr 10, 2023

View reviewed changes

ktmud approved these changes May 5, 2023

View reviewed changes

justinpark closed this Oct 12, 2023

justinpark reopened this Oct 12, 2023

fix: warning of nth-of-child

4ff10d4

justinpark force-pushed the fix--nth-of-child-warning branch from ec9c623 to 4ff10d4 Compare October 17, 2023 17:49

justinpark merged commit 16cc089 into apache:master Oct 17, 2023
26 checks passed

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Oct 18, 2023

michael-s-molina pushed a commit that referenced this pull request Oct 19, 2023

fix: warning of nth-child (#23638)

b380495

(cherry picked from commit 16cc089)

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: warning of nth-child (apache#23638)

8bf4ac0

mistercrunch added 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 13, 2024

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

fix: warning of nth-child (apache#23638)

50ed968

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: warning of nth-child #23638

fix: warning of nth-child #23638

justinpark commented Apr 10, 2023

justinpark commented Apr 10, 2023

rusackas left a comment

codecov bot commented Apr 10, 2023

rusackas commented Apr 13, 2023

github-actions bot commented Apr 13, 2023

rusackas commented Jul 25, 2023

fix: warning of nth-child #23638

fix: warning of nth-child #23638

Conversation

justinpark commented Apr 10, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

justinpark commented Apr 10, 2023

rusackas left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 10, 2023

Codecov Report

rusackas commented Apr 13, 2023

github-actions bot commented Apr 13, 2023

rusackas commented Jul 25, 2023