Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trino): Bump Trino version to address an IANA time zone issue #24069

Merged
merged 1 commit into from
May 16, 2023

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented May 16, 2023

SUMMARY

This PR bumps the minimal requirement for the python-trino-client as, per the 0.324.0 release notes, the latest release includes a vital fix to address an IANA time zone issue.

Note as part of this change I rebuilt the frozen requirements via:

> python3.9 -m pip install -r requirements/integration.txt
> pip-compile-multi --no-upgrade

which, in addition to bumping the trino package, removed some legacy requirement which likely were removed in previous PRs without refreezing the requirements.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title chore: Bump Trino chore: Bump Trino version to address an IANA time zone issue May 16, 2023
@john-bodley john-bodley requested a review from villebro May 16, 2023 04:53
@john-bodley john-bodley marked this pull request as ready for review May 16, 2023 04:53
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #24069 (f81d902) into master (78bc069) will not change coverage.
The diff coverage is n/a.

❗ Current head f81d902 differs from pull request most recent head 62db170. Consider uploading reports for the commit 62db170 to get more accurate results

@@           Coverage Diff           @@
##           master   #24069   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files        1942     1942           
  Lines       75215    75215           
  Branches     8145     8145           
=======================================
  Hits        51318    51318           
  Misses      21812    21812           
  Partials     2085     2085           
Flag Coverage Δ
hive 53.16% <ø> (ø)
mysql 78.91% <ø> (ø)
postgres 78.99% <ø> (ø)
presto 53.09% <ø> (ø)
python 82.77% <ø> (ø)
sqlite 77.51% <ø> (ø)
unit 53.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -125 to -126
greenlet==2.0.2
# via sqlalchemy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd really need to add linting to these requirements to make sure they're up to date. The python lint workflow would be perfect for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -130,7 +130,7 @@ sqlalchemy-bigquery==1.6.1
# via apache-superset
statsd==4.0.1
# via -r requirements/testing.in
trino==0.323.0
trino==0.324.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your Trino fix @john-bodley!

@villebro
Copy link
Member

Congrats on your Trino fix @john-bodley!

Oh nice, I hadn't noticed the author of said fix - congrats! 🎉

@john-bodley john-bodley changed the title chore: Bump Trino version to address an IANA time zone issue chore(trino): Bump Trino version to address an IANA time zone issue May 16, 2023
@john-bodley john-bodley merged commit 58e1bcd into apache:master May 16, 2023
@john-bodley john-bodley deleted the john-bodley--bump-trino branch May 16, 2023 13:54
john-bodley added a commit to airbnb/superset-fork that referenced this pull request May 16, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants