Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Dashboard import commands not correctly replacing charts #25102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lindenh
Copy link

@lindenh lindenh commented Aug 28, 2023

SUMMARY

Similar to #22208, the dashboard import commands would not replace charts when the overwrite flag was true, charts would be merged into one dashboard. This change fixes the command in the exact same way as that PR.

Fixes #22127

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a dashboard with a chart.
  2. Export the dashboard for import later.
  3. Modify the dashboard to remove the first chart and add a new one.
  4. Import the saved dashboard earlier (via UI OR /api/v1/dashboard/import)
  5. Notice both charts are in the dashboard

ADDITIONAL INFORMATION

  • Has associated issue: Import dashboard/assets with overwrite flag does not replace dashboards #22127
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Aug 28, 2023
@mdeshmu
Copy link
Contributor

mdeshmu commented Aug 29, 2023

Please fix pre-commit by running pre-commit run --all-files

@lindenh
Copy link
Author

lindenh commented Aug 29, 2023

Done, sorry about that!

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import dashboard/assets with overwrite flag does not replace dashboards
4 participants