Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dashboard): Add aria-label to filters and search forms #27968

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(Dashboard): Add aria-label to filters and search forms #27968

merged 1 commit into from
Apr 10, 2024

Conversation

geido
Copy link
Member

@geido geido commented Apr 10, 2024

SUMMARY

This PR improves accessibility of the Dashboard by adding aria-label to filters' forms and table search.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Use a screen reader
  2. Make sure filter forms are correctly labeled
  3. Make sure the search box of a Table chart is correctly labeled

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from kgabryje April 10, 2024 08:23
@geido geido merged commit 4202fba into master Apr 10, 2024
30 of 31 checks passed
@rusackas rusackas deleted the geido/fix/accessibility-form-labels branch April 10, 2024 14:25
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 11, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@geido @EnxDev
fix(Dashboard): Add aria-label to filters and search forms (apache#27968
e4aee4a 
)
michael-s-molina pushed a commit that referenced this pull request Apr 16, 2024
@geido @michael-s-molina
fix(Dashboard): Add aria-label to filters and search forms (#27968)
d6e0ff5 
(cherry picked from commit 4202fba)
betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
@geido @sadpandajoe
fix(Dashboard): Add aria-label to filters and search forms (#27968)
832f304 
(cherry picked from commit 4202fba)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@geido @qleroy
fix(Dashboard): Add aria-label to filters and search forms (apache#27968
a311919 
)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@geido @jzhao62
fix(Dashboard): Add aria-label to filters and search forms (apache#27968
b63e697 
)
@mistercrunch mistercrunch added 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @kgabryje @mistercrunch @michael-s-molina