Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(legacy-plugin-chart-map-box): bump supercluster to v8 #30305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(legacy-plugin-chart-map-box): bump supercluster to v8 #30305

wants to merge 1 commit into from
+33 −27

Conversation

birkskyum
Copy link

@birkskyum birkskyum commented Sep 17, 2024 •
edited
Loading

SUMMARY

Part of:

Modernizing the legacy-plugin-chart-map-box reduces the diff towards MapLibre.

This PR updates Supercluster from v4 to v8, which improves performance and memory use for of this plugin.

TESTING INSTRUCTIONS

  • set the mapbox key in .env
  • docker compose up
  • open a mapbox chart, and it should still show clusters like below image
Screenshot 2024-09-17 at 11 15 56

@rusackas , how does the review process generally work for these plugins? Are there some specific people who cover this part of the code?

@dosubot dosubot bot added change:frontend Requires changing the frontend viz:charts:map Related to Map charts labels Sep 17, 2024
github-actions[bot]
github-actions bot reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@birkskyum birkskyum mentioned this pull request Sep 17, 2024
Open
4 tasks
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@rusackas rusackas Awaiting requested review from rusackas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dependencies:npm plugins size/XS viz:charts:map Related to Map charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @michael-s-molina