Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fe): uplift FE packages to latest version #30357

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 21, 2024

chore(fe): uplift FE packages to latest version

SUMMARY

Changes:

  • Run npm audit fix.
  • Uplift fetch-mock to v11 + corresponding refactoring for superset-ui-core.
  • Uplift following packages to latest version.
    • @testing-library/react-hooks
    • @testing-library/jest-dom
    • webpack-cli
  • Move @types/* packages in superset-ui-core to devDependencies.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber hainenber force-pushed the superset-frontend-package-maintenance branch from bbb0c48 to b83781d Compare September 21, 2024 15:02
@hainenber hainenber marked this pull request as ready for review September 22, 2024 01:35
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Sep 22, 2024
@hainenber
Copy link
Contributor Author

  • Uplift fetch-mock to v11 + corresponding refactoring for superset-ui-core.
  • Uplift following packages to latest version.
    • @testing-library/react-hooks
    • @testing-library/jest-dom
    • webpack-cli

These are dev dependencies and any breakages are detected in frontend-build CI. Current check is green so these uplift are safe

Move @types/* packages in superset-ui-core to devDependencies.

Moving of @types/* package that are actual dependency will generate linting issue. This can be illustrated by moving @types/json-bigint into devDependencies in superset-ui-core. Current build is green so the uplift is safe.

image

Only risk is with npm audit fix as it might bump packages not respecting semver. However, from my inspection, they're mostly version bumps of dev dependencies (this is at 95% confidence interval :D)

@rusackas
Copy link
Member

rusackas commented Oct 3, 2024

Sorry for letting this sit too long. Looks like it needs needed a rebase, but barring that, it's fine with me if it passes CI!

…tors

Signed-off-by: hainenber <dotronghai96@gmail.com>
…to latest version + upgrade @testing-library/user-event to v13

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@rusackas rusackas force-pushed the superset-frontend-package-maintenance branch from 57325b6 to 1defb7e Compare October 3, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants