Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fe/src/dashboard): optional chaining for possibly nullable parent attribute in LayoutItem type #30442

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(fe/src/dashboard): optional chaining for possibly nullable parent attribute in LayoutItem type #30442

merged 1 commit into from
Oct 3, 2024

Conversation

hainenber
Copy link
Contributor

fix(fe/src/dashboard): optional chaining for possibly nullable parent attribute in LayoutItem type

SUMMARY

Add null checks via optional chaining for parent attribute of LayoutItem type. This has been done in the past, this PR is to roll out for remaining usages and re-type the attribute to be Partial.

Fixes #30418

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI should all pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
fix(fe/src/dashboard): optional chaining for possibly nullable parent…
17f6bc9 
… attribute in LayoutItem type

Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the dashboard Namespace | Anything related to the Dashboard label Sep 30, 2024
@hainenber
Copy link
Contributor Author

Change in package-lock.json is due to Dependabot's version bump without running npm ci by itself.

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Sep 30, 2024
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 1, 2024
@rusackas rusackas merged commit 2a458a4 into apache:master Oct 3, 2024
38 of 39 checks passed
@hainenber hainenber deleted the fix-nullable-parent-layout-item branch October 4, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
dashboard Namespace | Anything related to the Dashboard dependencies:npm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard Filter 'useFilterScope' Error
4 participants
@hainenber @justinpark @rusackas @michael-s-molina