Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): don't discard controls on deprecated #30447

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

Currently, if a column or metric name changes in Explore, any previously selected control items disappear. This can lead to confusion during debugging, as the control items mentioned in the error message are not actually displayed.
This commit modifies explore to display a warning message in such cases, allowing the user to manually delete and modify the control items.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--warning-markdown.mov

After:

after--warning-markdown.mov

TESTING INSTRUCTIONS

Create a chart with a dataset
Select a column / a metric in the control and then save
Edit the dataset and then change the name of the above selected column/metric
Revisit the chart and then see the error message

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore:control Related to the controls panel of Explore label Sep 30, 2024
@mistercrunch
Copy link
Member

Minor comment from watching the screen caps, but I'm thinking an error exclamation-point-in-a-red-circle would be better than the yellow warning you used. That yellow warning is use to raise attention to something that's not breaking like the other place we use the warning is when we want to show that "this filter is inherited from the dashboard context and won't be saved ..."

@justinpark
Copy link
Member Author

Updated the indicator with the error icon.

Screenshot 2024-10-01 at 2 00 31 PM

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit b627011 into apache:master Oct 4, 2024
34 checks passed
@justinpark
Copy link
Member Author

@sadpandajoe could you add this fix on 4.1?

sadpandajoe pushed a commit that referenced this pull request Oct 7, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:control Related to the controls panel of Explore packages size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants