Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable lint PT009 'use regular assert over self.assert.*' #30521

Merged
merged 3 commits into from
Oct 7, 2024
Merged

chore: enable lint PT009 'use regular assert over self.assert.*' #30521

merged 3 commits into from
Oct 7, 2024
+2,217 −2,421

Commits on Oct 5, 2024

  1. chore: enable lint PT009 'use regular assert over self.assert.*' 

    I just got bit by some old school self.assertEqual which is not good as the pytest-augmented, simple assert. Just leveraging the rule, running automated --fix for things it can fix and adding NOQA to the few it didn't auto-fix
    @mistercrunch
    mistercrunch committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    1b5da51 View commit details
    Browse the repository at this point in the history

  2. import re

    @mistercrunch
    mistercrunch committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ff29293 View commit details
    Browse the repository at this point in the history

  3. fix test file

    @mistercrunch
    mistercrunch committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ca88983 View commit details
    Browse the repository at this point in the history