Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect type in config.py #30564

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: Incorrect type in config.py #30564

merged 1 commit into from
Oct 9, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Multiple language programmer error 😄 The type of the SQLGLOT_DIALECTS_EXTENSIONS configuration was incorrect.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch and removed size/XS labels Oct 9, 2024
@michael-s-molina michael-s-molina merged commit 7a8e8f8 into master Oct 9, 2024
34 of 35 checks passed
@michael-s-molina michael-s-molina self-assigned this Oct 9, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 9, 2024
@michael-s-molina @sadpandajoe
fix: Incorrect type in config.py (#30564)
0eaa8c5 
(cherry picked from commit 7a8e8f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

Assignees

@michael-s-molina michael-s-molina

Labels
v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
Apache Superset 4.1
Status: Cherried
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-s-molina @justinpark