Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Druid post aggregations (continued) #410

Closed
wants to merge 8 commits into from

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Apr 28, 2016

Hi, this is still not so easy to use, but at least I can get the post aggregated average value using this now. It's at least another step forward.
This feature is very important to me and many others as you can see in the comments in the original pull requests ( #133 ).
Please consider merging it to the master if you think this is kind of ready. Or please give me feedbacks so I can make the whole feature work sooner.

Currently only TableViz is supported. If you think it looks good, I can add support to more other viz.
Thanks

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.28% when pulling b9941d4 on x4base:post_agg2 into bd47a29 on airbnb:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.10% when pulling f4e8b06 on x4base:post_agg2 into bd47a29 on airbnb:master.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage decreased (-0.2%) to 80.749% when pulling f4e8b06 on x4base:post_agg2 into bd47a29 on airbnb:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.17% when pulling 152b47c on x4base:post_agg2 into bd47a29 on airbnb:master.

@coveralls
Copy link

coveralls commented Apr 29, 2016

Coverage Status

Coverage decreased (-0.5%) to 80.525% when pulling 152b47c on x4base:post_agg2 into bd47a29 on airbnb:master.

@x4base
Copy link
Contributor Author

x4base commented Apr 29, 2016

Now aggregators are treated as if they are just normal metrics

@mistercrunch
Copy link
Member

I did a little bit more work on this locally and wanted to basically define post aggs as metrics, using the DruidMetric model as opposed to a new model. Then it's just a matter of figuring out which metrics are post aggs and generating the write query.

@x4base
Copy link
Contributor Author

x4base commented Apr 29, 2016

Do you mean you have another local branch in your machine that is similar to this pull request? Based on your old pull request or this request? Will you push your commit? Do I have to change anything in this PR or just wait for your commit?

@mistercrunch
Copy link
Member

Opting for #418 instead of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants