[SIP-9] Introduce TypeScript #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtinec
force-pushed
the
typescript-setup
branch
3 times, most recently
from
f1bed58
to
1cebfc9
Compare
kristw
approved these changes
Oct 18, 2018
williaster
reviewed
Oct 23, 2018
superset/assets/webpack.config.js
Outdated
| @@ -102,8 +109,12 @@ const config = { | |||
| }, | |||
| }, | |||
| resolve: { | |||
| extensions: ['.js', '.jsx'], | |||
| alias: { | |||
| '@': path.resolve(APP_DIR, './src'), | |||
There was a problem hiding this comment.
wanted to gauge thoughts on making this more readable like @src or @root, etc. instead of just @.
I don't care that strongly, but do think more readability is generally good.
There was a problem hiding this comment.
Agree. More readability is always good. :)
Any preference for @src VS @root? @williaster @kristw @mistercrunch I think I like them equally. hehe.
There was a problem hiding this comment.
Okey-dokey. Renaming it to @src shortly. :)
There was a problem hiding this comment.
sgtm, don't have a strong pref / like them equally, too 😃
- Introduce TypeScript and co to both source and tests - Define alias for src directory in both webpack config and jest config so we can avoid using long relative paths like ../../src in both source and tests - Type check feature flags system to prevent typos of flag names - Change the feature flags system and the flags on window instead of populating them through the state tree. When introducing the first SCOPED_FILTER feature flag, it became too difficult to pipe the flags through the state initializers and layers of components and containers (the resulting code is hard to read and has a handful of methods taking an additional feature flag map parameter). Given that feature flags don't change throughout the life time of the app, it is better to leave them on window for easy access than piping them through the global state tree, which is meant to store the state of the app which changes frequently. - Add a barebone filter panel that only shows when the SCOPED_FILTER feature flag is on
- Fixing linting for Javascript files importing Typscript files - Also fix linting for Javascript files that now leverage the webpack alias for the src directory - up Typescript and type def versions
williaster
approved these changes
Oct 24, 2018
xtinec
force-pushed
the
typescript-setup
branch
from
1cebfc9
to
ed67d6d
Compare
|
My pleasure! 🙌 Btw, wound up renaming the webpack alias for the src directory from |
Codecov Report
@@ Coverage Diff @@
## master #6120 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 47 47
Lines 9362 9362
=======================================
Hits 7201 7201
Misses 2161 2161Continue to review full report at Codecov.
|
|
TypeScript FTW! |
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [SIP-9] Introduce TypeScript - Introduce TypeScript and co to both source and tests - Define alias for src directory in both webpack config and jest config so we can avoid using long relative paths like ../../src in both source and tests - Type check feature flags system to prevent typos of flag names - Change the feature flags system and the flags on window instead of populating them through the state tree. When introducing the first SCOPED_FILTER feature flag, it became too difficult to pipe the flags through the state initializers and layers of components and containers (the resulting code is hard to read and has a handful of methods taking an additional feature flag map parameter). Given that feature flags don't change throughout the life time of the app, it is better to leave them on window for easy access than piping them through the global state tree, which is meant to store the state of the app which changes frequently. - Add a barebone filter panel that only shows when the SCOPED_FILTER feature flag is on * Remove unnecessary dev-dependency on gl * - Adding linting for TypeScript files via tslint. - Fixing linting for Javascript files importing Typscript files - Also fix linting for Javascript files that now leverage the webpack alias for the src directory - up Typescript and type def versions * Rename src directory's webpack alias from @ to src to be more explicit.
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch @betodealmeida @williaster @kristw @john-bodley @ttannis