Make time grains translatable #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.006%) to 81.968% when pulling 8b37fb0e6012f4fb15881c554e8764533d696f3c on xrmx:transmodels into e29d71d on airbnb:master. |
| @@ -23,7 +23,7 @@ | |||
| from flask_appbuilder import Model | |||
| from flask_appbuilder.models.mixins import AuditMixin | |||
| from flask_appbuilder.models.decorators import renders | |||
| from flask_babelpkg import gettext as _ | |||
| from flask_babelpkg import lazy_gettext as _ | |||
There was a problem hiding this comment.
Wait that means you made everything else that didn't need to be lazy use lazy_gettext
There was a problem hiding this comment.
The other two users which are exceptions should be fine.
|
Ooops, I can't merge, can you rebase? |
|
Done |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
This was referenced Dec 22, 2022
This was referenced Dec 23, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.