Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New endpoint that receives SQL and returns data as JSON #842

Merged
merged 2 commits into from
Jul 30, 2016
Merged

New endpoint that receives SQL and returns data as JSON #842

merged 2 commits into from
Jul 30, 2016

Conversation

mistercrunch
Copy link
Member

@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 81.145% when pulling ed8223e on mistercrunch:sql_json into 299e31f on airbnb:master.

bkyryliuk
bkyryliuk reviewed Jul 29, 2016
View reviewed changes
caravel/views.py
@@ -1214,6 +1214,7 @@ def select_star(self, database_id, table_name):
@log_this
def runsql(self):
"""Runs arbitrary sql and returns and html table"""
# TODO deprecate in fabor on `sql_json`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fabor/favor

@bkyryliuk
Copy link
Member

LGTM,
couple minor comments.
Thanks @mistercrunch

@coveralls
Copy link

coveralls commented Jul 30, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 81.145% when pulling c27e9cf on mistercrunch:sql_json into 299e31f on airbnb:master.

@mistercrunch
Copy link
Member Author

Comments addressed, mergin'

@mistercrunch mistercrunch merged commit ee9141a into apache:master Jul 30, 2016
@mistercrunch mistercrunch deleted the sql_json branch July 30, 2016 05:39
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @coveralls @bkyryliuk