Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FAB to 2.2.2 #9004

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Bump FAB to 2.2.2 #9004

merged 2 commits into from
Jan 23, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 23, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Bump FAB to 2.2.2 to support #8960

Improvements and Bug fixes on 2.2.2:

Fix, [mvc] List page's pagination start with 1 (#1216)
Fix, AttributeError in manager.py when a permission is null (#1217)
Fix, [api] using default method name when unspecified in method_permission_name (#1235)
New, [api] New, http 403 forbidden on default responses (#1237)
New, [mvc] [api] exclude and include route methods (#1234)
New, [mvc] [security] make userstatschartview optional (#1239)
New, [mvc] Disable old API flag and tests (#1244)
Fix, [mvc] jinja2 crashes with defined actions and removed action routes (#1245)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@dpgaspar dpgaspar marked this pull request as ready for review January 23, 2020 15:57
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the conflict

@mistercrunch
Copy link
Member

Oh, I merged my PR with the pointer to rc2... Let's fix this here.

@dpgaspar
Copy link
Member Author

Already did, let's let the CI run

@codecov-io
Copy link

Codecov Report

Merging #9004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9004   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         367      367           
  Lines       11680    11680           
  Branches     2863     2863           
=======================================
  Hits         6910     6910           
  Misses       4591     4591           
  Partials      179      179
Impacted Files Coverage Δ
...rset/assets/src/dashboard/actions/sliceEntities.js 9.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4389a...a5d39e2. Read the comment docs.

@dpgaspar dpgaspar merged commit 6f1c931 into apache:master Jan 23, 2020
@dpgaspar dpgaspar deleted the feature/bump-fab-2-2-2 branch January 23, 2020 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants