Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build error and warnings when building VTA_TSIM with TVM #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

k0nze
Copy link

@k0nze k0nze commented Sep 18, 2023

When building VTA_TSIM from TVM, an error occurred, which was fixed by changing the signature of DPIModule (src/dpi/module.cc) from std::string to tvm::runtime::String. Additionally, override statements were added to DPIModule methods which override virtual methods of DPIModuleNode (src/dpi/module.h) to get rid of warnings when building VTA_TSIM.

…ule.cc) to fix inheritance error when building VTA_TSIM with TVM and added override statements to DPIModule methods that override methods of the base class DPIModuleNode.
@Lunderberg
Copy link
Contributor

Good catch, and looks like this was introduced by apache/tvm#14902 may in May.

@k0nze
Copy link
Author

k0nze commented Oct 31, 2023

Are there plans to merge this PR and #38?

@Lunderberg
Copy link
Contributor

Unfortunately, I don't have commit privs for the tvm-vta repo, but I've reached out to ask on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants