Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add auto-updating last-successful branch #10056

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Conversation

driazati
Copy link
Member

@driazati driazati commented Jan 25, 2022

This adds a script that runs on a cron to discover the last commit where CI all passed (every job was successful and tvm-ci/branch is included) and updates a git branch last-successful that tracks this commit from main. This can be used for checking out the latest unbroken TVM, which can be useful for developers wanting a good changeset to base their changes on or for infra needing a clean, up-to-date TVM.

Also soliciting better names than green

@Mousius
Copy link
Member

Mousius commented Jan 25, 2022

I suggest last-successful as a tag so we're not coupled to the colour 😸

@driazati driazati changed the title [ci] Add auto-updating 'green' tag [ci] Add auto-updating last-successful tag Jan 25, 2022
@driazati driazati force-pushed the auto_green branch 2 times, most recently from ca470d2 to 7879c29 Compare January 25, 2022 21:52
@driazati driazati force-pushed the auto_green branch 3 times, most recently from 443cd49 to 2492592 Compare January 26, 2022 20:26
.github/workflows/update_tag.yml Outdated Show resolved Hide resolved
tests/scripts/update_tag.py Outdated Show resolved Hide resolved
tests/scripts/update_tag.py Outdated Show resolved Hide resolved
@driazati driazati force-pushed the auto_green branch 2 times, most recently from 44fd642 to 4f0f497 Compare January 27, 2022 19:50
@areusch
Copy link
Contributor

areusch commented Feb 1, 2022

one problem here is that a tag doesn't automatically update with git fetch. A branch would. it's a little confusing to have a branch instead of a tag, but a branch is confined to origin/ namespace and will auto-update with git fetch. i think we should switch to updating a branch to avoid confusing behavior where last-successful is not updated after a fetch.

cc @leandron @mbrookhart if there are other ideas

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

It has been a while since this PR was updated, @leandron @mbrookhart @AndrewZhaoLuo @driazati @areusch please leave a review or address the outstanding comments

@driazati driazati changed the title [ci] Add auto-updating last-successful tag [ci] Add auto-updating last-successful branch Feb 2, 2022
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to me, @areusch can you take another look?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

It has been a while since this PR was updated, @leandron @mbrookhart @Mousius @AndrewZhaoLuo @driazati @areusch please leave a review or address the outstanding comments

@driazati
Copy link
Member Author

driazati commented Feb 9, 2022

Sorry about the overactive bot everyone, it's still missing some checks to look at before sending out these pings

This adds a script that runs on a cron to discover the last commit where CI all passed (every job was successful and `tvm-ci/branch` is included) and updates a git tag `green` to point to this commit on `main`. This can be used for checking out the latest unbroken TVM, which can be useful for developers wanting a good changeset to base their changes on or for infra needing a clean, up-to-date TVM.
@Mousius Mousius self-assigned this Feb 15, 2022
@Mousius Mousius merged commit 7d831e1 into apache:main Feb 21, 2022
@Mousius
Copy link
Member

Mousius commented Feb 21, 2022

Let's get this in so we can start iterating if we need to 😸

pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
This adds a script that runs on a cron to discover the last commit where CI all passed (every job was successful and `tvm-ci/branch` is included) and updates a git tag `green` to point to this commit on `main`. This can be used for checking out the latest unbroken TVM, which can be useful for developers wanting a good changeset to base their changes on or for infra needing a clean, up-to-date TVM.
@fpedd
Copy link

fpedd commented Apr 13, 2023

What happened to this branch? The CI job got manually disabled about 5 months ago, it seems.

@driazati
Copy link
Member Author

I filed an issue with the reason for disabling and potential fix: #14618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants