[Op][Topi] 5 ops can accept unsigned integers as indices

[yuanfz98]

Hello community,

This PR links to #10064. 5 ops (scatter, scatter_add, scatter_nd, unravel_index, adv_index) accept unsigned integers as indices. Somehow unravel_index with uint indices may raise

Check failed: y != 0 (0 vs. 0) 

in function

tvm/src/arith/const_int_bound.cc

Line 486 in e6af874

ICHECK_NE(y, 0);

.

I tried to figure out why shape[v] can be 0 in

tvm/include/tvm/topi/transform.h

Line 383 in 7b9fd1e

cur_val = indexdiv(indices_divs.back(), shape[v]);

,
but I failed to understand.

Thank reviewers for your help and your time speeding in CR.

cc @AndrewZhaoLuo

[AndrewZhaoLuo]

Debugging I've worked the issue to likely src/tir/transforms/narrow_datatype.cc, my guess analysis here does not take into account uint types

[AndrewZhaoLuo]

#10102 <-- fix here. There is another error now with unravel index now though. You can try digging more, or you can drop unravel_index for later PR (which I recommend)

[AndrewZhaoLuo]

LGTM mostly, just lmk the plan to deal with unravel_index

[yuanfz98]

LGTM mostly, just lmk the plan to deal with unravel_index

Thanks for your help! I prefer to drop unravel_index and open a PR later.

[AndrewZhaoLuo]

LGTM