Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR][Schedule] Update compact_dataflow constraint #10158

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented Feb 3, 2022

compact_dataflow is a very strong constraint, which requires all the blocks in the sub-AST to be complete or reduction blocks. Currently, there are two primitives that use such property:

  • compute-at: the total scope is compact_dataflow.
  • parallel/bind/vectorize: the total scope is compact_dataflow.

However, requiring all the scope to be compact_dataflow is too strict that some correct transformations are banned. (please see the added test cases). Here I updated the requirements:

  • compute-at: only requires the input block is complete or reduction
  • parallel/bind/vectorize: only requires compact_dataflow under the input loop.

cc @spectrometerHBH @junrushao1994 @vinx13

@junrushao junrushao merged commit 96416c4 into apache:main Feb 3, 2022
mbs-octoml pushed a commit to mbs-octoml/mbs-tvm that referenced this pull request Feb 5, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@Hzfengsy Hzfengsy deleted the compact_dataflow branch February 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants