-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USMP] Register hill climb algorithm #10182
Conversation
No reason, these two PRs went in parallely. In fact, I discussed with @d-smirnov today of doing this today. |
@manupa-arm Thank you for your fast response. If you would like be to add anything alse to this mini PR or if your would perfer to add the changes yourself, feels free to do so. I think the CI job crashed due to an issue which is not related to this PR. Should I retrigger it with a new push? |
Hi @PhilippvK , Once again, thanks for picking this up :) Only thing I could think of enabling this in the test here (which should be easy enough to do) : tvm/tests/python/relay/aot/test_crt_aot_usmp.py Lines 210 to 216 in 470a1c7
and yes... please retrigger. |
That sounds like a good idea! I will give it a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @PhilippvK ! |
* USMP: Register hill_climb algo in algorithms map * USMP: Add missing space to assertion message * USMP: Integrate hill_climb algo in test_crt_aot_usmp
While the hill-climbing algorithm for the Unified Static Memory Planner (see #8404, #9565) was recently added to TVM in #9704, it currently can not be used by the default TVM flow due to this error:
I was able to fix this by just adding an entry in the mentioned algorithms map.
If there was a reason whythe Hill Climb allocator was not registred until now, feel free to let me know.