[Refactor] Clean up type relations that are declared as template for no reason #10236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
jwfromm,
anijain2305,
ZihengJiang,
jroesch,
slyubomirsky,
icemelon,
MarisaKirisame,
yzhliu,
vinx13,
mbrookhart,
zhiics,
wweic and
junrushao
as code owners
masahi
changed the title
masahi
force-pushed
the
conv-typrel-cleanup
branch
from
deac9d1
to
33a2950
Compare
masahi
force-pushed
the
conv-typrel-cleanup
branch
from
33a2950
to
8dca6ee
Compare
masahi
changed the title
jroesch
approved these changes
Feb 15, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During investigation of #10235, I found most of type rel in
relay/op/nn/convolution.hare unnecessarily declared as template, probably the result of repeated copy-pasting of existing code. This is not only embarrassing, but also extremely annoying when making a simple modification to one of type rels: Sincerelay/op/nn/convolution.his included in multiple *.cc file, it causes totally unnecessary build. I fixed all of them in anger 🤦♂️@junrushao1994 @comaniac