Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Allow execution on target or simulator from HexagonLauncher #10454

Merged
merged 1 commit into from
Mar 3, 2022
Merged

[Hexagon] Allow execution on target or simulator from HexagonLauncher #10454

merged 1 commit into from
Mar 3, 2022

Conversation

kparzysz-quic
Copy link
Contributor

Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on simulator instead of a hardware device.

This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR to specify the location of the hexagon_api binaries. If unset, the code will look for the binaries in the same way as before this patch.

@kparzysz-quic
Copy link
Contributor Author

cc: @mehrdadh @masahi

@masahi
Copy link
Member

masahi commented Mar 2, 2022

please fix the lint issues

@masahi masahi self-assigned this Mar 2, 2022
Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on
simulator instead of a hardware device.

This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR
to specify the location of the hexagon_api binaries. If unset, the
code will look for the binaries in the same way as before this patch.
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to enable these tests to run in Hexagon CI in a follow up PR?

@kparzysz-quic
Copy link
Contributor Author

@mehrdadh Yes, I'd like to do that. I'm also going to be switching our downstream CI to use the HexagonLauncher mechanism.

@masahi masahi merged commit 5e33ffc into apache:main Mar 3, 2022
@Hzfengsy Hzfengsy mentioned this pull request Mar 3, 2022
ziqiangxu8457 pushed a commit to ziqiangxu8457/tvm that referenced this pull request Mar 6, 2022
…apache#10454)

Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on
simulator instead of a hardware device.

This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR
to specify the location of the hexagon_api binaries. If unset, the
code will look for the binaries in the same way as before this patch.
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
…apache#10454)

Setting ANDROID_SERIAL_NUMBER=simulator will execute the tests on
simulator instead of a hardware device.

This patch also introduces an environment variable HEXAGON_RPC_LIB_DIR
to specify the location of the hexagon_api binaries. If unset, the
code will look for the binaries in the same way as before this patch.
@kparzysz-quic kparzysz-quic deleted the hexagon-sim-launcher branch June 22, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants