-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTING] Check for toolchain when marking reference system tests #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Mar 18, 2022
As part of this any failing tests have been marked for follow up as part of apache#10673. This depends on fixes in apache#10659, apache#10672 and apache#10674 to scope other tests correctly.
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Mar 18, 2022
As part of this any failing tests have been marked for follow up as part of apache#10673. This depends on fixes in apache#10659, apache#10672 and apache#10674 to scope other tests correctly.
Mousius
force-pushed
the
check-for-toolchain
branch
from
March 25, 2022 11:04
b9d9996
to
75c605d
Compare
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Mar 25, 2022
As part of this any failing tests have been marked for follow up as part of apache#10673. This depends on fixes in apache#10659, apache#10672 and apache#10674 to scope other tests correctly.
This mimics the behaviour of aot_test_utils.py to ensure the tests don't start running when the toolchain isn't available.
Mousius
force-pushed
the
check-for-toolchain
branch
from
March 25, 2022 11:18
75c605d
to
a24fff2
Compare
manupak
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! @Mousius |
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Mar 25, 2022
As part of this any failing tests have been marked for follow up as part of apache#10673. This depends on fixes in apache#10659, apache#10672 and apache#10674 to scope other tests correctly.
manupak
pushed a commit
that referenced
this pull request
Mar 25, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This mimics the behaviour of aot_test_utils.py to ensure the tests don't start running when the toolchain isn't available.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
As part of this any failing tests have been marked for follow up as part of apache#10673. This depends on fixes in apache#10659, apache#10672 and apache#10674 to scope other tests correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics the behaviour of aot_test_utils.py to ensure the tests don't start running when the toolchain isn't available.