Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] resolve int64/32 for AttrStmtNode #10983

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Conversation

ganler
Copy link
Contributor

@ganler ganler commented Apr 12, 2022

Similar issues as:
#10172
#9582
#10519
#10571
#10584

Integer mismatch when constructingIterVal. Triggered when compiling models on GPU (that's why the AttrStmtNode's logic is reached). A triggering example model is attached: model.onnx.zip

@masahi

@ganler
Copy link
Contributor Author

ganler commented Apr 12, 2022

The fix has passed CI but just want to kinda refine the code to be more general according to @altanh 's suggestion (#10969 (comment)).

@ganler
Copy link
Contributor Author

ganler commented Apr 13, 2022

@masahi According to #10969, maybe let's use this PR?

@masahi
Copy link
Member

masahi commented Apr 13, 2022

Can you add a test case, maybe from #10969?

@masahi masahi merged commit 61a9269 into apache:main Apr 13, 2022
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Apr 15, 2022
* main: (527 commits)
  [hexagon] 'add_hvx' test to explore HVX usage. (apache#10604)
  [COMMUNITY] @yzh119 -> Reviewer (apache#10993)
  [Metaschedule] Make custom schedule_rule registration optional (apache#10975)
  [ONNX] Add imports for BERT contrib operators (apache#10949)
  sort axes (apache#10985)
  [Hexagon] Remove HexagonBuffer external constructor and support (apache#10978)
  [CI] Update GPU image (apache#10992)
  [Runtime][Vulkan] Add RGP support to TVM for vulkan device (apache#10953)
  [FIX] resolve int64/32 for AttrStmtNode (apache#10983)
  [TVMC] Allow output module name to be passed as a command line argument (apache#10962)
  [ONNX] Add MatMulInteger importer (apache#10450)
  [COMMUNITY] @guberti -> Reviewer (apache#10976)
  Support `qnn.conv2d` in FoldExplicitPading (apache#10982)
  change Hexagon docker version (apache#10981)
  remove exception handling of autotvm xgboost extract functions (apache#10948)
  [CUDNN] Add partitioning support for conv2d and log_softmax (apache#10961)
  [Hexagon][LLVM] Enable/test tensorized Hexagon DMA on 2d transformed layout (apache#10905)
  [Hexagon] Move aot/graph_executor interactions into launcher (apache#10907)
  [HEXAGON] Split huge 1D DMA Transfers into smaller transfers with legal sizes. (apache#10971)
  [CI][DOCKER] Add pytest-lazy-fixture to images (apache#10970)
  ...
Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
* resolve int64/32 for AttrStmtNode

* rm debug header

* refine

* add test case

* lint
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
* resolve int64/32 for AttrStmtNode

* rm debug header

* refine

* add test case

* lint
@ganler ganler deleted the attr-int-mismatch branch June 13, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants