Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Populate setuptools description with README.md #11078

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

leandron
Copy link
Contributor

Adds the description metadata for the setuptools descriptor file setup.py with the contents of our existing README.md, which is a common practice.

This will be reflected in the page for our package on PyPI in pages like https://pypi.org/project/apache-tvm/0.9.dev1125/

cc @tqchen @areusch @Mousius @driazati @grant-arm for reviews

Adds the description metadata for the setuptools descriptor file
`setup.py` with the contents of our existing README.md, which is
a common practice.
@Mousius
Copy link
Member

Mousius commented Apr 20, 2022

Much better than what we have today:

Screenshot 2022-04-20 at 16 43 50

Copy link
Contributor

@grant-arm grant-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple tiny comments but 🚀

python/setup.py Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
@areusch
Copy link
Contributor

areusch commented Apr 22, 2022

+1 for this, though agree with the others' comments and will let them approve

leandron and others added 2 commits April 25, 2022 17:11
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
@leandron leandron force-pushed the package_description branch 2 times, most recently from bc40a93 to 994a113 Compare April 25, 2022 17:07
@areusch areusch merged commit 4330c21 into apache:main Apr 26, 2022
@leandron
Copy link
Contributor Author

shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
* [Python] Populate setuptools description with README.md

Adds the description metadata for the setuptools descriptor file
`setup.py` with the contents of our existing README.md, which is
a common practice.

* Update python/setup.py

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>

* Update python/setup.py

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>

* Import pathlib and apply black formats.

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
* [Python] Populate setuptools description with README.md

Adds the description metadata for the setuptools descriptor file
`setup.py` with the contents of our existing README.md, which is
a common practice.

* Update python/setup.py

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>

* Update python/setup.py

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>

* Import pathlib and apply black formats.

Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants