-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Populate setuptools description with README.md #11078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the description metadata for the setuptools descriptor file `setup.py` with the contents of our existing README.md, which is a common practice.
Mousius
approved these changes
Apr 20, 2022
grant-arm
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
driazati
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple tiny comments but 🚀
+1 for this, though agree with the others' comments and will let them approve |
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
leandron
force-pushed
the
package_description
branch
2 times, most recently
from
April 25, 2022 17:07
bc40a93
to
994a113
Compare
leandron
force-pushed
the
package_description
branch
from
April 25, 2022 17:08
994a113
to
11f97c8
Compare
areusch
approved these changes
Apr 26, 2022
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* [Python] Populate setuptools description with README.md Adds the description metadata for the setuptools descriptor file `setup.py` with the contents of our existing README.md, which is a common practice. * Update python/setup.py Co-authored-by: driazati <9407960+driazati@users.noreply.github.com> * Update python/setup.py Co-authored-by: driazati <9407960+driazati@users.noreply.github.com> * Import pathlib and apply black formats. Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
juda
pushed a commit
to juda/tvm
that referenced
this pull request
Jun 21, 2022
* [Python] Populate setuptools description with README.md Adds the description metadata for the setuptools descriptor file `setup.py` with the contents of our existing README.md, which is a common practice. * Update python/setup.py Co-authored-by: driazati <9407960+driazati@users.noreply.github.com> * Update python/setup.py Co-authored-by: driazati <9407960+driazati@users.noreply.github.com> * Import pathlib and apply black formats. Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the description metadata for the setuptools descriptor file
setup.py
with the contents of our existing README.md, which is a common practice.This will be reflected in the page for our package on PyPI in pages like https://pypi.org/project/apache-tvm/0.9.dev1125/
cc @tqchen @areusch @Mousius @driazati @grant-arm for reviews