Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule] Enable Task Filtering #11512

Merged
merged 1 commit into from
May 31, 2022

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented May 31, 2022

This PR allows relay.backend.MetaScheduleExtractTask to take an extra argument filter_func which filters out tasks that don't need tuning. The counterpart of AutoScheduler is traverse_to_get_io_tensors.

@junrushao
Copy link
Member Author

CC: @comaniac @Hzfengsy @zxybazh

@Hzfengsy
Copy link
Member

Can we add testcases?

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Echo @Hzfengsy's comment that we may need a test case.

src/relay/backend/task_extraction.cc Show resolved Hide resolved
@junrushao
Copy link
Member Author

@Hzfengsy thanks for asking! It's pretty hard to add a unittest given we will need an actual end-to-end network that takes hours to run...In this particular case, it might be good to leave it to future integration test instead

@junrushao junrushao requested a review from comaniac May 31, 2022 07:42
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, unit tests for task extraction don't need to run tune. Instead, it only needs to extract tasks and verify their number and workloads. However, if MetaSchedule doesn't have unit tests for task extractions yet, we could of course add it later.

@junrushao
Copy link
Member Author

I'm happy to add a simple unittest without tuning :-)

@junrushao junrushao force-pushed the feature/2022-05-30/task-filtering branch from 16a8851 to 5f96e8a Compare May 31, 2022 20:28
@junrushao junrushao merged commit a71536a into apache:main May 31, 2022
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
This PR allows `relay.backend.MetaScheduleExtractTask` to take an extra argument `filter_func` which filters out tasks that don't need tuning. The counterpart of AutoScheduler is `traverse_to_get_io_tensors`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants