Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1d-softmax schedule. #11719

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix 1d-softmax schedule. #11719

merged 1 commit into from
Jun 15, 2022

Conversation

lazycal
Copy link
Contributor

@lazycal lazycal commented Jun 14, 2022

One sophisticated softmax's TE schedule assumes >= 2D input (eg,

tvm/python/tvm/topi/cuda/softmax.py

Line 86 in d92a773

xo, xi = s[output].split(output.op.axis[1], nparts=num_thread)
), and raises IndexError for 1D input. This PR checks tensor rank and falls back to default schedule when rank=1.

@masahi

@masahi masahi merged commit d2e2f71 into apache:main Jun 15, 2022
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
@lazycal
Fix 1d-softmax schedule. (apache#11719)
56f29d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazycal @masahi