Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule] Allow MultiLevelTilingTensorCore rule to specify multiple tensor intrin groups #12113

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Jul 15, 2022

This PR made it possible to specify multiple tensor core intrinsics (for different dtype) at the same time.

cc @masahi @spectrometerHBH @junrushao1994

tensor_intrin.get_wmma_intrin_group(write_reuse_scope, _in_dtype, _out_dtype, _trans_b)
for _in_dtype in in_dtype
for _out_dtype in out_dtype
for _trans_b in trans_b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a compute, isn't there only one group that's valid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is to allow one single rule to apply to different workloads (different dtypes).

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it should be the responsibility of a user to select the right dtype etc for a given workload, but I can imagine that this is useful for tuning e2e models having different kinds of workload with a single rule.

@masahi masahi merged commit 895f79f into apache:main Jul 16, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants