Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Assert some unittests are not skipped in CI #12436

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

gigiblender
Copy link
Contributor

@gigiblender gigiblender commented Aug 15, 2022

This PR adds a script that does a diff of skipped tests between the latest successful build on the main and the current branch. Then, it posts a comment with the report on the open PR.

#11670

@driazati @areusch

cc @Mousius

@gigiblender gigiblender changed the title [CI] Assert some unittests are not skipped [CI] Assert some unittests are not skipped in CI Aug 15, 2022
@github-actions
Copy link
Contributor

Built docs for commit 183f513 can be found here.

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great! This is a nice way to fix this without putting too much burden on developers. It’d be nice to see a end to end test in your tvm fork too

tests/scripts/github_skipped_tests_comment.py Outdated Show resolved Hide resolved
Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general structure looks good, just a couple more small comments

tests/python/ci/test_ci.py Outdated Show resolved Hide resolved
tests/python/ci/test_ci.py Outdated Show resolved Hide resolved
tests/scripts/github_skipped_tests_comment.py Outdated Show resolved Hide resolved
tests/scripts/github_skipped_tests_comment.py Outdated Show resolved Hide resolved
tests/scripts/github_skipped_tests_comment.py Show resolved Hide resolved
@driazati driazati merged commit 56b7c8a into apache:main Aug 25, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This PR adds a script that does a diff of skipped tests between the latest successful build on the main and the current branch. Then, it posts a comment with the report on the open PR. 

apache#11670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants